[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] style: Format string macro should have a space between quote
From: |
Glenn Washburn |
Subject: |
Re: [PATCH] style: Format string macro should have a space between quotes |
Date: |
Thu, 4 Mar 2021 16:46:50 -0600 |
On Thu, 4 Mar 2021 20:03:34 +0100
Daniel Kiper <daniel.kiper@oracle.com> wrote:
> Does this patch fix all such issues in the GRUB source code?
>
> Daniel
I don't know and its unclear the scope of your question. However, this
is the grep I used to find these instances:
grep -rnE '\"PRI|PRI[a-zA-Z_0-9]+\"' <repo root>
Glenn
> On Wed, Mar 03, 2021 at 07:51:04PM -0600, Glenn Washburn wrote:
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
> > ---
> > grub-core/disk/luks2.c | 38 +++++++++++++++++++-------------------
> > grub-core/fs/xfs.c | 4 ++--
> > 2 files changed, 21 insertions(+), 21 deletions(-)
> >
> > diff --git a/grub-core/disk/luks2.c b/grub-core/disk/luks2.c
> > index 7460d7b58..125e8609a 100644
> > --- a/grub-core/disk/luks2.c
> > +++ b/grub-core/disk/luks2.c
> > @@ -272,7 +272,7 @@ luks2_get_keyslot (grub_luks2_keyslot_t *k,
> > grub_luks2_digest_t *d, grub_luks2_s grub_json_getuint64 (&k->idx,
> > &keyslot, NULL) || grub_json_getchild (&keyslot, &keyslot, 0) ||
> > luks2_parse_keyslot (k, &keyslot))
> > - return grub_error (GRUB_ERR_BAD_ARGUMENT, "Could not parse
> > keyslot index %"PRIuGRUB_SIZE, keyslot_json_idx);
> > + return grub_error (GRUB_ERR_BAD_ARGUMENT, "Could not parse
> > keyslot index %" PRIuGRUB_SIZE, keyslot_json_idx);