grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [SECURITY PATCH 116/117] templates: Disable the os-prober by default


From: John Paul Adrian Glaubitz
Subject: Re: [SECURITY PATCH 116/117] templates: Disable the os-prober by default
Date: Wed, 3 Mar 2021 21:13:04 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1

Hi Daniel!

On 3/3/21 8:38 PM, Daniel Kiper wrote:
>> I'm not sure I'm able to follow the motivation to keep the naming scheme
>> as is.
>>
>> If I have an option called "DISABLE_FEATURE_X", then I would expect setting
>> it to "true" would mean that the feature is disabled not the other way 
>> around.
> 
> Huh! I have just realized that we did not drop "if" change from earlier 
> version
> of patch which also changed variable name. Interestingly doc update is 
> correct.
> Anyway, sorry for the confusion. I asked Alex to post a fix for this.

I'm glad we were able to resolve this. I was already questioning my sanity :D.

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer - glaubitz@debian.org
`. `'   Freie Universitaet Berlin - glaubitz@physik.fu-berlin.de
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913




reply via email to

[Prev in Thread] Current Thread [Next in Thread]