[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error |
Date: |
Sat, 27 Feb 2021 13:05:09 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Feb 18, 2021 at 08:47:13PM -0600, Glenn Washburn wrote:
> For some reason PRIuGRUB_UINT64_T is not expanding to llu, but to lu, which
> causes the format string check to fail. Use literal and force cast until
> this is debugged.
I think the problem is that currently BF64_DECODE() uses "1ULL". I think it
should
look like this
#define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), ((grub_uint64_t) 1) <<
(len))
instead of
#define BF64_DECODE(x, low, len) P2PHASE((x) >> (low), 1ULL << (len))
Same or similar for other macros there.
I would prefer if you fix macros in include/grub/zfs/spa.h first and
then do proper fix here.
Daniel
- Re: [PATCH v4 08/13] error: Use %p format code for pointer types, (continued)
- [PATCH v4 07/13] efi: Format string error in grub_error, Glenn Washburn, 2021/02/18
- [PATCH v4 06/13] pgp: Format code for grub_error is incorrect, Glenn Washburn, 2021/02/18
- [PATCH v4 10/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit arg in grub_error, Glenn Washburn, 2021/02/18
- [PATCH v4 09/13] error: Use format code PRIxGRUB_UINT64_T for 64-bit uint argument in grub_error, Glenn Washburn, 2021/02/18
- [PATCH v4 13/13] error: Do compile-time format string checking on grub_error, Glenn Washburn, 2021/02/18
- [PATCH v4 05/13] grub_error: Use format code PRIuGRUB_SIZE for variables of type grub_size_t, Glenn Washburn, 2021/02/18
- [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error, Glenn Washburn, 2021/02/18
- Re: [PATCH v4 12/13] error: Use format code llu for 64-bit uint bp->blk_prop in grub_error,
Daniel Kiper <=
- [PATCH v4 11/13] error: Use format code PRIuGRUB_UINT64_T for 64-bit typed fileblock in grub_error, Glenn Washburn, 2021/02/18
- Re: [PATCH v4 00/13] error: Do compile-time format string checking on grub_error, Daniel Kiper, 2021/02/27