grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNK


From: Daniel Kiper
Subject: Re: [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNKNOWN for now
Date: Wed, 16 Dec 2020 13:13:52 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Tue, Dec 15, 2020 at 05:31:07PM -0600, Glenn Washburn wrote:
> Check to make sure that source disk has a known size. If not, print debug
> message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is
> set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing
> continues. So this is probably a bit conservative. However, 3 of the cases
> seem pathological, and the other, biosdisk, happens when booting from a cd.
> Since I doubt booting from a LUKS2 volume on a cd is a big use case, we'll
> error until someone complains.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>

Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]