[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNK
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNKNOWN for now |
|
Date: |
Wed, 16 Dec 2020 13:13:52 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Dec 15, 2020 at 05:31:07PM -0600, Glenn Washburn wrote:
> Check to make sure that source disk has a known size. If not, print debug
> message and return error. There are 4 cases where GRUB_DISK_SIZE_UNKNOWN is
> set (biosdisk, obdisk, ofdisk, and uboot), and in all those cases processing
> continues. So this is probably a bit conservative. However, 3 of the cases
> seem pathological, and the other, biosdisk, happens when booting from a cd.
> Since I doubt booting from a LUKS2 volume on a cd is a big use case, we'll
> error until someone complains.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- [PATCH v9 0/6] Cryptodisk fixes for v2.06 redux, Glenn Washburn, 2020/12/15
- [PATCH v9 1/6] luks2: Convert to crypt sectors from grub native sectors, Glenn Washburn, 2020/12/15
- [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNKNOWN for now, Glenn Washburn, 2020/12/15
- Re: [PATCH v9 2/6] luks2: Do not handle disks of size GRUB_DISK_SIZE_UNKNOWN for now,
Daniel Kiper <=
- [PATCH v9 3/6] luks2: Better error handling when setting up the cryptodisk, Glenn Washburn, 2020/12/15
- [PATCH v9 4/6] mips: Enable __clzdi2(), Glenn Washburn, 2020/12/15
- [PATCH v9 5/6] misc: Add grub_log2ull macro for calculating log base 2 of 64-bit integers, Glenn Washburn, 2020/12/15
- [PATCH v9 6/6] luks2: Use grub_log2ull to calculate log_sector_size and improve readability, Glenn Washburn, 2020/12/15