[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 8/9] efi: Only register shim_lock verifier if shim_lock proto
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH 8/9] efi: Only register shim_lock verifier if shim_lock protocol is found and SB enabled |
|
Date: |
Wed, 16 Dec 2020 10:29:01 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
On 12/15/20 1:36 PM, Daniel Kiper wrote:
[snip]
>
>> the unexpected build error.
>>
>> ../../grub-core/commands/efi/shim_lock.c:121:21: error: implicit declaration
>> of function ‘grub_efi_get_secureboot’; did you mean
>> ‘grub_efi_get_device_path’? [-Werror=implicit-function-declaration]
>> 121 | if (sl == NULL || grub_efi_get_secureboot () !=
>> GRUB_EFI_SECUREBOOT_MODE_ENABLED)
>>
>> FWIW, the trivial patch I use to get around above build error is
>> included.
>
> Yeah, I spotted the same and fixed it before pushing the patches.
>
Sorry about that. I did build and test the patches but it may be
that I reordered a little bit before posting and introduced this.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
- [PATCH 4/9] efi: Make shim_lock GUID and protocol type public, (continued)
- [PATCH 4/9] efi: Make shim_lock GUID and protocol type public, Javier Martinez Canillas, 2020/12/03
- [PATCH 5/9] efi: Return grub_efi_status_t from grub_efi_get_variable(), Javier Martinez Canillas, 2020/12/03
- [PATCH 6/9] efi: Add a function to read EFI variables with attributes, Javier Martinez Canillas, 2020/12/03
- [PATCH 9/9] loader/linux: Report the UEFI Secure Boot status to the Linux kernel, Javier Martinez Canillas, 2020/12/03
- [PATCH 7/9] efi: Add secure boot detection, Javier Martinez Canillas, 2020/12/03
- [PATCH 8/9] efi: Only register shim_lock verifier if shim_lock protocol is found and SB enabled, Javier Martinez Canillas, 2020/12/03
Re: [PATCH 0/9] Add UEFI Secure Boot detection and report the status to Linux, Daniel Kiper, 2020/12/04