[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] at_keyboard: Fix keyboards that report IBM PC AT scan codes |
|
Date: |
Mon, 14 Dec 2020 11:44:02 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.0 |
Hello Vladimir,
On 12/11/20 3:08 PM, Vladimir 'phcoder' Serbinenko wrote:
> On Fri, Dec 4, 2020 at 5:53 AM Renaud Métrich <rmetrich@redhat.com> wrote:
>>
>> Hi,
>>
>> Testing the proposed patch on my old Asus N53SN in Legacy failed: as soon as
>> at_keyboard is selected, the keys are corrupted and it's impossible to do
>> anything.
>>
>> Digging into this, it appears that query_mode() returns 2 (so set2 needs to
>> be used), but in fact internally the keycode are the ones expected by set1.
>
> This is because the patch doesn't take into account that controller is
> in "translate" mode.
> @Javier Martinez Canillas : Can you make your patch check whether
> KEYBOARD_AT_TRANSLATE is set ?
>
Thanks a lot for you feedback. Renaud is working on a new patch that
takes this into account and will post to the mailing list after doing
some testing on the machines that where having the problem.
Best regards,
Javier