grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] loopback: Do not automaticaly replace existing loopback d


From: Daniel Kiper
Subject: Re: [PATCH v2] loopback: Do not automaticaly replace existing loopback dev, error instead
Date: Thu, 10 Dec 2020 17:55:20 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Mon, Dec 07, 2020 at 10:52:16PM -0600, Glenn Washburn wrote:
> On Fri, 4 Dec 2020 13:34:44 +0100
> Daniel Kiper <dkiper@net-space.pl> wrote:
>
> > On Thu, Dec 03, 2020 at 07:57:11PM -0600, Glenn Washburn wrote:
> > > If there is a loopback device with the same name as the one to be
> > > created, instead of closing the old one and replacing it with the
> > > new one, return an error instead. If the loopback device was
> > > created, its probably being used by something and just replacing it
> > > may cause grub to crash unexpectedly. This fixes obvious problems
> > > like `loopback d (d)/somefile'. Its not too onerous to force the
> > > user to delete the loopback first with the `-d' switch.
> > >
> > > Signed-off-by: Glenn Washburn <development@efficientek.com>
> >
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> >
> > Daniel
> >
> > PS May I ask you to create new thread for new version of the patches
> >    instead of attaching them to previous threads?
>
> These two patches were not meant to be a thread together, ie separate
> patches, which was why I was treating them separately.  I can see how
> that might be confusing now.

I was also referring to the LUKS2 patches, sorry if I was not precise,
which are always connected to the first thread created. This is confusing
too. Could you create separate thread for each version of patchset in
the future?

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]