[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v8 01/18] disk: Rename grub_disk_get_size to grub_disk_native
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v8 01/18] disk: Rename grub_disk_get_size to grub_disk_native_sectors |
Date: |
Wed, 9 Dec 2020 18:39:34 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Dec 08, 2020 at 04:45:32PM -0600, Glenn Washburn wrote:
> The function grub_disk_get_size is confusingly named because it actually
> returns a sector count where the sectors are sized in the grub native sector
> size. Rename to something more appropriate.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> Suggested-by: Daniel Kiper <daniel.kiper@oracle.com>
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>
The proper order is:
Suggested-by: Daniel Kiper <daniel.kiper@oracle.com>
Signed-off-by: Glenn Washburn <development@efficientek.com>
Reviewed-by: Patrick Steinhardt <ps@pks.im>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
First I suggested the patch, you wrote it, Patrick reviewed the patch
and finally I did it.
I will fix it before committing.
Daniel
- [PATCH v8 00/18] Cryptodisk fixes for v2.06 redux, Glenn Washburn, 2020/12/08
- [PATCH v8 01/18] disk: Rename grub_disk_get_size to grub_disk_native_sectors, Glenn Washburn, 2020/12/08
- Re: [PATCH v8 01/18] disk: Rename grub_disk_get_size to grub_disk_native_sectors,
Daniel Kiper <=
- [PATCH v8 03/18] whitespace: convert 8 spaces to tabs, Glenn Washburn, 2020/12/08
- [PATCH v8 07/18] luks2: Use more intuitive object name instead of json index in user messages, Glenn Washburn, 2020/12/08
- [PATCH v8 04/18] luks2: Remove unused argument in grub_error, Glenn Washburn, 2020/12/08
- [PATCH v8 08/18] luks2: Rename json index variables to names that they are obviously json indexes, Glenn Washburn, 2020/12/08
- [PATCH v8 11/18] cryptodisk: Add macros GRUB_TYPE_U_MAX/MIN(type) to replace literals, Glenn Washburn, 2020/12/08