[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 05/17] luks2: Add json_slot_key member to struct grub_luks
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v7 05/17] luks2: Add json_slot_key member to struct grub_luks2_keyslot/segment/digest |
Date: |
Mon, 7 Dec 2020 21:02:39 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sun, Dec 06, 2020 at 02:29:06PM +0100, Patrick Steinhardt wrote:
> On Fri, Dec 04, 2020 at 10:43:34AM -0600, Glenn Washburn wrote:
> > This allows code using these structs to know the named key associated with
> > these json data structures. In the future we can use these to provide better
> > error messages to the user.
> >
> > Get rid of idx variable in luks2_get_keyslot() which was overloaded to be
> > used for both keyslot and segment slot keys.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Personally, I'd have named them `json_slot_idx`. But you've already done
> so much work on improving the code that I don't want this to be the
> reason to not give an SOB, especially considering that it's a strict
> improvement anyway. So:
>
> Signed-off-by: Patrick Steinhardt <ps@pks.im>
I can change this to json_slot_idx before committing if Glenn does not
object. Otherwise Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- Re: [PATCH v7 03/17] luks2: Remove unused argument in grub_error, (continued)
[PATCH v7 17/17] luks2: Use grub_log2ull to calculate log_sector_size and improve readability, Glenn Washburn, 2020/12/04
[PATCH v7 02/17] misc: Add parentheses around ALIGN_UP and ALIGN_DOWN arguments, Glenn Washburn, 2020/12/04
[PATCH v7 05/17] luks2: Add json_slot_key member to struct grub_luks2_keyslot/segment/digest, Glenn Washburn, 2020/12/04
[PATCH v7 14/17] whitespace: convert 8 spaces to tabs, Glenn Washburn, 2020/12/04
Re: [PATCH v7 00/17] Cryptodisk fixes for v2.06 redux, Patrick Steinhardt, 2020/12/06