[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 06/15] luks2: Rename variable i to keyslot_idx in luks2_ge
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v4 06/15] luks2: Rename variable i to keyslot_idx in luks2_get_keyslot. |
Date: |
Mon, 16 Nov 2020 17:37:14 +0100 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sun, Nov 15, 2020 at 10:43:55AM +0100, Patrick Steinhardt wrote:
> On Fri, Nov 06, 2020 at 10:44:26PM -0600, Glenn Washburn wrote:
> > Variables named i are usually looping variables, so rename to keyslot_idx to
> > allow for easier reading of luks2_get_keyslot.
> >
> > Signed-off-by: Glenn Washburn <development@efficientek.com>
>
> Reviewed-by: Patrick Steinhardt <ps@pks.im>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- [PATCH v4 00/15] Cryptodisk fixes for v2.06 redux, Glenn Washburn, 2020/11/06
- [PATCH v4 02/15] cryptodisk: Rename offset in grub_cryptodisk_t to offset_sectors., Glenn Washburn, 2020/11/06
- [PATCH v4 06/15] luks2: Rename variable i to keyslot_idx in luks2_get_keyslot., Glenn Washburn, 2020/11/06
- [PATCH v4 01/15] cryptodisk: Rename total_length field in grub_cryptodisk_t to total_sectors., Glenn Washburn, 2020/11/06
- [PATCH v4 04/15] types: Define GRUB_CHAR_BIT based on compiler macro instead of using literal., Glenn Washburn, 2020/11/06
- [PATCH v4 03/15] luks2: Rename source disk variabled named 'disk' to 'source' as in luks.c., Glenn Washburn, 2020/11/06
- [PATCH v4 08/15] luks2: Split idx into three variables: keyslot_key, digest_key, segment_key., Glenn Washburn, 2020/11/06