[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] cryptodisk: make the password getter and additional argu
|
From: |
James Bottomley |
|
Subject: |
Re: [PATCH 1/3] cryptodisk: make the password getter and additional argument to recover_key |
|
Date: |
Fri, 13 Nov 2020 07:44:44 -0800 |
|
User-agent: |
Evolution 3.34.4 |
On Fri, 2020-11-13 at 00:02 -0600, Glenn Washburn wrote:
[...]
> diff --git a/grub-core/disk/geli.c b/grub-core/disk/geli.c
> > index e9d23299a..5514c16a3 100644
> > --- a/grub-core/disk/geli.c
> > +++ b/grub-core/disk/geli.c
> > @@ -398,7 +398,8 @@ configure_ciphers (grub_disk_t disk, const char
> > *check_uuid, }
> >
> > static grub_err_t
> > -recover_key (grub_disk_t source, grub_cryptodisk_t dev)
> > +recover_key (grub_disk_t source, grub_cryptodisk_t dev,
> > + grub_passwd_cb *password_get)
> > {
> > grub_size_t keysize;
> > grub_uint8_t digest[GRUB_CRYPTO_MAX_MDLEN];
> > @@ -442,7 +443,7 @@ recover_key (grub_disk_t source,
> > grub_cryptodisk_t dev) source->partition ? "," : "", tmp ? : "",
> > dev->uuid);
> > grub_free (tmp);
>
> In luks.c and luks2.c below, grub_printf_ is made conditional, but
> not here. It probably should be.
Yes, I can add that.
James