grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] travis: Fix sparc64 build


From: Petr Vorel
Subject: Re: [PATCH 2/4] travis: Fix sparc64 build
Date: Tue, 22 Sep 2020 11:05:47 +0200

Hi Daniel,

...
> > >    # Build all selected GRUB targets.
> > >    - for target in $GRUB_TARGETS; do
> > > -      plat=${target#*-};
> > > -      arch=${target%-*};
> > > +      arch=$(echo $target | cut -d- -f1);
> > > +      plat=$(echo $target | cut -d- -f2);

> > I think it should be: plat=$(echo $target | cut -d- -f2-);
> > Note dash after "2"...
> No, this way it breaks sparc64 [1] (and does not help to fix mips [2]
> nor risc32 either).

> It looks like it's this error:
> configure: error: platform "ieee1275-raw" is not supported for target CPU 
> "sparc64"

Yes, the correct build without - at the end gets plat == "ieee1275", which is
correct.
https://travis-ci.org/github/pevik/grub/jobs/729143839

Kind regards,
Petr

> but I need to debug it more to see what's wrong.
Comment mips and risc32 under their patches.


Kind regards,
Petr

> > Though I would prefer this:
> >   arch=$(echo "$target" | cut -d - -f 1);
> >   plat=$(echo "$target" | cut -d - -f 2-);

> > Daniel

> Kind regards,
> Petr

> [1] https://travis-ci.org/github/pevik/grub/jobs/728077121
> [2] https://travis-ci.org/github/pevik/grub/jobs/728077123
> [3] https://travis-ci.org/github/pevik/grub/jobs/728077126



reply via email to

[Prev in Thread] Current Thread [Next in Thread]