grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] travis: Fix sparc64 build


From: Petr Vorel
Subject: Re: [PATCH 2/4] travis: Fix sparc64 build
Date: Tue, 22 Sep 2020 00:19:20 +0200

Hi Daniel,

thanks for merging first commit.

> On Wed, Sep 09, 2020 at 10:02:19PM +0200, Petr Vorel wrote:
> > Instead non-existing sparc64-ieee1275 format use all 3 sparc64 formats:
> > sparc64-ieee1275-{aout,cdcore,raw}.

> > Signed-off-by: Petr Vorel <pvorel@suse.cz>
> > ---
> >  .travis.yml | 6 +++---
> >  1 file changed, 3 insertions(+), 3 deletions(-)

> > diff --git a/.travis.yml b/.travis.yml
> > index 4bd05a30a..d019a0172 100644
> > --- a/.travis.yml
> > +++ b/.travis.yml
> > @@ -40,8 +40,8 @@ script:

> >    # Build all selected GRUB targets.
> >    - for target in $GRUB_TARGETS; do
> > -      plat=${target#*-};
> > -      arch=${target%-*};
> > +      arch=$(echo $target | cut -d- -f1);
> > +      plat=$(echo $target | cut -d- -f2);

> I think it should be: plat=$(echo $target | cut -d- -f2-);
> Note dash after "2"...
No, this way it breaks sparc64 [1] (and does not help to fix mips [2]
nor risc32 either).

It looks like it's this error:
configure: error: platform "ieee1275-raw" is not supported for target CPU 
"sparc64"

but I need to debug it more to see what's wrong.

Kind regards,
Petr

> Though I would prefer this:
>   arch=$(echo "$target" | cut -d - -f 1);
>   plat=$(echo "$target" | cut -d - -f 2-);

> Daniel

Kind regards,
Petr

[1] https://travis-ci.org/github/pevik/grub/jobs/728077121
[2] https://travis-ci.org/github/pevik/grub/jobs/728077123
[3] https://travis-ci.org/github/pevik/grub/jobs/728077126



reply via email to

[Prev in Thread] Current Thread [Next in Thread]