[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error mess
|
From: |
Glenn Washburn |
|
Subject: |
Re: [PATCH v3 3/9] luks2: Fix use of incorrect index and some error messages |
|
Date: |
Mon, 21 Sep 2020 06:45:04 +0000 (UTC) |
Sep 8, 2020 6:58:48 AM Daniel Kiper <daniel.kiper@oracle.com>:
> On Mon, Sep 07, 2020 at 05:27:41PM +0200, Patrick Steinhardt wrote:
>> From: Glenn Washburn <development@efficientek.com>
>
> It seems to me this patch should be split into two and and begs for
> commit message improvement. In general it would be nice to know why
> we need these fixes.
This patch is doing two things, fixing a bug and making the code more
understandable. My original patch just fixed the bug, then Patrick suggested
making it more readable. I can split it into two patches.
The bug it's fixing is that the keyslot index variable was being used to index
the digests and segments, whereas the digest and segment index variables should
be used to index their respective json arrays.
Glenn
[PATCH v3 5/9] luks2: Improve error reporting when decrypting/verifying key, Patrick Steinhardt, 2020/09/07
[PATCH v3 6/9] cryptodisk: Unregister cryptomount command when removing module, Patrick Steinhardt, 2020/09/07