Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.

[Paul Menzel]

Dear Glenn,


Am 29.08.20 um 01:30 schrieb Glenn Washburn:
> LODEVICES is not an array variable and should not be accessed as such. This
> allows the f2fs test to pass as it was failing because a device name had a
> space prepended to the path.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>   tests/util/grub-fs-tester.in | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> index bc14a05ca..bfc425e1f 100644
> --- a/tests/util/grub-fs-tester.in
> +++ b/tests/util/grub-fs-tester.in
> @@ -796,7 +796,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" "$MAXLOGSECSIZE" 
> 1); do
>                     MOUNTFS=ext2
>                     "mkfs.ext2" -L "$FSLABEL" -q "${MOUNTDEVICE}"  ;;
>                 xf2fs)
> -                   "mkfs.f2fs" -l "$FSLABEL" -q "${LODEVICES[0]}" ;;
> +                   "mkfs.f2fs" -l "$FSLABEL" -q "${MOUNTDEVICE}" ;;
>                 xnilfs2)
>                     "mkfs.nilfs2" -L "$FSLABEL" -b $BLKSIZE  -q 
> "${MOUNTDEVICE}" ;;
>                 xext2_old)

Tested-by: Paul Menzel <pmenzel@molgen.mpg.de>


Kind regards,

Paul