grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.


From: Daniel Kiper
Subject: Re: [PATCH] tests: F2FS test should use MOUNTDEVICE like other tests.
Date: Thu, 17 Sep 2020 16:19:56 +0200
User-agent: NeoMutt/20170113 (1.7.2)

Adding Jaegeuk and Paul...

On Fri, Aug 28, 2020 at 06:30:25PM -0500, Glenn Washburn wrote:
> LODEVICES is not an array variable and should not be accessed as such. This
> allows the f2fs test to pass as it was failing because a device name had a
> space prepended to the path.
>
> Signed-off-by: Glenn Washburn <development@efficientek.com>
> ---
>  tests/util/grub-fs-tester.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/util/grub-fs-tester.in b/tests/util/grub-fs-tester.in
> index bc14a05ca..bfc425e1f 100644
> --- a/tests/util/grub-fs-tester.in
> +++ b/tests/util/grub-fs-tester.in
> @@ -796,7 +796,7 @@ for LOGSECSIZE in $(range "$MINLOGSECSIZE" 
> "$MAXLOGSECSIZE" 1); do
>                   MOUNTFS=ext2
>                   "mkfs.ext2" -L "$FSLABEL" -q "${MOUNTDEVICE}"  ;;
>               xf2fs)
> -                 "mkfs.f2fs" -l "$FSLABEL" -q "${LODEVICES[0]}" ;;
> +                 "mkfs.f2fs" -l "$FSLABEL" -q "${MOUNTDEVICE}" ;;

LGTM...

Jaegeuk, Paul does this fix work for you?

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]