Re: [PATCH v3 0/9] Cryptodisk fixes for v2.06

[Patrick Steinhardt]

On Mon, Sep 07, 2020 at 05:27:27PM +0200, Patrick Steinhardt wrote:
> this is the third version of this patchset, collecting various fixes for
> LUKS2/cryptodisk for the upcoming release of GRUB v2.06.
> 
> Besides my Reviewed-by tag, the only thing that changed is the final
> patch by Glenn. Quoting him:
> 
>     > The main difference with this patch is that sector_size is renamed to
>     > log_sector_size, grub has enough inaccurate or misleading names.
>     > Additionally, rename LOG_SECTOR_SIZE to LUKS_LOG_SECTOR_SIZE and
>     > CRYPT_LOG_SECTOR_SIZE to GRUB_CRYPTODISK_IV_LOG_SIZE and moved to
>     > cryptodisk.h.  Also a comment was reworded for clarity.

A subset of these patches has been applied by Daniel, leaving us at
(rearranged for better readability):

> Glenn Washburn (6):
>   cryptodisk: Fix incorrect calculation of start sector
>   cryptodisk: Unregister cryptomount command when removing module

Both were picked.

>   luks2: Fix use of incorrect index and some error messages
>   luks2: grub_cryptodisk_t->total_length is the max number of device
>     native sectors
>   cryptodisk: Fix cipher IV mode 'plain64' always being set as 'plain'
>   cryptodisk: Properly handle non-512 byte sized sectors

These weren't yet and got some feedback.

> Patrick Steinhardt (3):
>   json: Remove invalid typedef redefinition
>   luks: Fix out-of-bounds copy of UUID
>   luks2: Improve error reporting when decrypting/verifying key

All three of these have been applied.

@Glenn: seeing that all of my patches have been applied, do you want to
take over your remaining four patches again? That'd probably make the
process easier for both of us.

Patrick

signature.asc
Description: PGP signature