grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Quoting issues in Bash script `grub-fs-tester` causes F2FS test failure


From: Paul Menzel
Subject: Quoting issues in Bash script `grub-fs-tester` causes F2FS test failure
Date: Fri, 28 Aug 2020 11:19:00 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0

Dear GRUB folks,


Running `sudo env make -e check VERBOSE=yes SUBDIRS=` the F2FS is one of the two tests failing. It returns 255.

Running only the specific test

    sudo env TESTS=f2fs_test make -e check VERBOSE=yes SUBDIRS=

which runs

    sudo ./grub-fs-tester f2fs

and using `set -ex` in `grub-fs-tester` the call below has quoting issues.

                xf2fs)
                    "mkfs.f2fs" -l "$FSLABEL" -q "${LODEVICES[0]}"

fails due to the loop device being passed in single quotes, which does not exist with the leading space.

     + LODEVICE=/dev/loop11
     + LODEVICES=' /dev/loop11'

+ mkfs.f2fs -l 'grub_;/testé䏌䐓䏕киритiurewfceniuewruewnuuireurevueurnievrewfnerfcnevirivinrewvnirewnivrewiuvcrewvnuewvrrrewniuerwreiuviurewiuviurewnuvewnvrenurnunuvrevuurerejiremvreijnvvcreivire nverivnreivrevnureiorfnfrvoeoiroireoireoifrefoieroifoirvcreivire nverivnreivrevnureiorfnfrvoeoiroireoireoifrefoieroifoircreivire nverivnreivrevnureiorfnfrvoeoiroireoireoifrefoieroifoireoifoiq' -q ' /dev/loop11'
     FAIL f2fs_test (exit status: 255)

Is there a Bash expert in here, able to fix it?


Kind regards,

Paul



reply via email to

[Prev in Thread] Current Thread [Next in Thread]