[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/6] grub-install: Fix inverted test for NLS enabled when cop
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH 1/6] grub-install: Fix inverted test for NLS enabled when copying locales |
|
Date: |
Thu, 28 May 2020 08:50:27 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 |
On 5/25/20 9:02 PM, Daniel Kiper wrote:
> From: Martin Whitaker <fsf@martin-whitaker.me.uk>
>
> Commit 3d8439da8 (grub-install: Locale depends on nls) attempted to avoid
> copying locale files to the target directory when NLS was disabled.
> However the test is inverted, and it does the opposite.
>
> Signed-off-by: Martin Whitaker <fsf@martin-whitaker.me.uk>
> Signed-off-by: Daniel Kiper <daniel.kiper@oracle.com>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
- [PATCH 0/6] GRUB: Bundle of various fixes and cleanups, Daniel Kiper, 2020/05/25
- [PATCH 2/6] net/http: Return an error on HTTP error responses, Daniel Kiper, 2020/05/25
- [PATCH 6/6] efi/tpm: Fix typo in grub_efi_tpm2_protocol struct, Daniel Kiper, 2020/05/25
- [PATCH 4/6] tpm: Drop unneeded code, Daniel Kiper, 2020/05/25
- [PATCH 1/6] grub-install: Fix inverted test for NLS enabled when copying locales, Daniel Kiper, 2020/05/25
- Re: [PATCH 1/6] grub-install: Fix inverted test for NLS enabled when copying locales,
Javier Martinez Canillas <=
- [PATCH 3/6] docs: Fix devicetree command description, Daniel Kiper, 2020/05/25
- [PATCH 5/6] i386/efi/init: Drop bogus include, Daniel Kiper, 2020/05/25