Re: [PATCH v3 2/5] configure: Set gnu99 C language standard by default

[Daniel Axtens]

Javier Martinez Canillas <address@hidden> writes:

> Hello Daniel,
>
> On 5/19/20 3:47 AM, Daniel Axtens wrote:
>> Javier Martinez Canillas <address@hidden> writes:
>> 
>>> Hello Daniel,
>>>
>>> On 5/18/20 5:49 PM, Daniel Kiper wrote:
>>>
>>> [snip]
>>>
>>>>>
>>>>> Without this patch, clang-9 fails on the use of nested functions in
>>>>> commit cb2f15c54489 ("normal/main: Search for specific config files for
>>>>> netboot") - I'll send a fix for that shortly. If I revert that as a
>>>>> temporary measure, clang will build.
>>>>
>>>> Javier, could you take a look at this too?
>> 
>> Javier,
>> 
>> I think this is as simple as un-nesting the function, but you know the
>> code base better than me, so I'll leave it to you unless you
>> particularly want me to handle it.
>>
>
> Yes, that should be enough. I'll post a patch but I don't have a clang
> build environment so I would appreciate if you can test it.

Will do.

>
>> Regards,
>> Daniel
>> 
>
> Best regards,
> -- 
> Javier Martinez Canillas
> Software Engineer - Desktop Hardware Enablement
> Red Hat