Re: [MULTIBOOT2 SPEC PATCH v3 2/4] multiboot2: Use .gitignore files

[Daniel Kiper]

On Fri, May 08, 2020 at 06:50:47AM +0200, Hans Ulrich Niedermann wrote:
> Add .gitignore file and remove the obsolete .bzrignore file.
>
> The doc/.gitignore file is generated by gnulib-tool so we keep
> that file in addition to the top-level .gitignore file which
> covers everything else in the subdirectory tree.

If it is generated by gnulib-tool why do we need to create it?

> Signed-off-by: Hans Ulrich Niedermann <address@hidden>
>
>  delete mode 100644 .bzrignore
>  create mode 100644 .gitignore
>  create mode 100644 doc/.gitignore
>
> diff --git a/.bzrignore b/.bzrignore
> deleted file mode 100644
> index fda459816..000000000
> --- a/.bzrignore
> +++ /dev/null
> @@ -1,30 +0,0 @@
> -gendocs.sh
> -lib
> -m4
> -.deps
> -Makefile
> -autom4te.cache
> -config.cache
> -config.h
> -config.log
> -config.status
> -stamp-h
> -stamp-h1
> -doc/Makefile
> -doc/*.info*
> -doc/.deps
> -doc/gendocs_template
> -doc/mdate-sh
> -doc/Makefile.in
> -doc/boot.S.texi
> -doc/kernel
> -doc/kernel.c.texi
> -doc/multiboot.h.texi
> -doc/texinfo.tex
> -Makefile.in
> -aclocal.m4
> -config.h.in
> -configure
> -depcomp
> -install-sh
> -missing
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 000000000..01823be9c
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1,49 @@
> +# Generated by "autogen.sh"
> +/gendocs.sh
> +/lib/
> +/m4/
> +
> +/NEWS
> +/README
> +
> +Makefile.in
> +
> +/aclocal.m4
> +/autom4te.cache/
> +/compile
> +/config.h.in
> +/configure
> +/depcomp
> +/doc/mdate-sh
> +/doc/texinfo.tex
> +/install-sh
> +/INSTALL
> +/missing
> +
> +# Generated by "configure"
> +Makefile
> +.deps/

Slash, "/", prefix?

> +
> +/config.h
> +/config.log
> +/config.status
> +/stamp-h1
> +
> +# Generated by "make"
> +/doc/*.c.texi
> +/doc/*.h.texi
> +/doc/*.S.texi
> +/doc/multiboot.info*
> +/doc/stamp-vti
> +/doc/version.texi
> +
> +*.o

Could you be more consistent and list prefixed and not prefixed variants
in the same order in each section?

Daniel