[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 4/5 v2] gitignore: Add leading slashes where appropriate
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 4/5 v2] gitignore: Add leading slashes where appropriate |
Date: |
Thu, 7 May 2020 14:05:57 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Thu, Apr 30, 2020 at 09:54:52PM +0200, Hans Ulrich Niedermann wrote:
> Going through the list of gitignore patterns without a leading slash,
> this adds a leading slash where it appears to have been forgotten.
>
> Also, for patterns matching directories, add a trailing slash.
I would split this patch into two. Other patches looks good. So, if you
split this patch you can add to all patches
Reviewed-by: Daniel Kiper <address@hidden>
> Some gitignore patterns like ".deps/" or "Makefile" clearly should
> match everywhere, so those definitively need no leading slash.
>
> For some patterns like "contrib" or "ascii.bitmaps", it is unclear
> where in the source tree they should match. Those patterns are
> kept as they are, matching the patterns in the whole tree of
> subdirectories.
>
> Signed-off-by: Hans Ulrich Niedermann <address@hidden>
Daniel
[Prev in Thread] |
Current Thread |
[Next in Thread] |
- Re: [PATCH 4/5 v2] gitignore: Add leading slashes where appropriate,
Daniel Kiper <=