Re: [PATCH 1/5] gitignore: Group patterns with and without slash

[Daniel Kiper]

On Fri, Apr 24, 2020 at 12:43:47AM +0200, Hans Ulrich Niedermann wrote:
> Group the .gitignore patterns into two groups:
>
>   * Patterns including a slash, i.e. matching only relative to the
>     .gitignore file's directory.
>
>   * Pattern not including a slash, i.e. matching files anywhere in
>     the .gitignore file's directory and all of its subdirectories.

I would reverse order of these sentences to make them in line with the
order in .gitignore file.

> Signed-off-by: Hans Ulrich Niedermann <address@hidden>
> ---
>  .gitignore | 81 ++++++++++++++++++++++++++++--------------------------
>  1 file changed, 42 insertions(+), 39 deletions(-)
>
> diff --git a/.gitignore b/.gitignore
> index 819cd185d..87280ba24 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -1,3 +1,4 @@
> +# Ignore patterns in this directory and all subdirectories
>  *~
>  00_header
>  10_*
> @@ -30,9 +31,6 @@ config.sub
>  configure
>  core_compress_test
>  DISTLIST
> -docs/*.info
> -docs/stamp-vti
> -docs/version.texi
>  ehci_test
>  example_grub_script_test
>  example_scripted_test
> @@ -45,25 +43,18 @@ gensymlist.sh
>  gentrigtables
>  gentrigtables.exe
>  gettext_strings_test
> -/gnulib
>  grub-bin2h
> -/grub-bios-setup
> -/grub-bios-setup.exe
>  grub_cmd_date
>  grub_cmd_echo
>  grub_cmd_regexp
>  grub_cmd_set_date
>  grub_cmd_sleep
> -/grub-editenv
> -/grub-editenv.exe
>  grub-emu
>  grub-emu-lite
>  grub-emu.exe
>  grub-emu-lite.exe
>  grub_emu_init.c
>  grub_emu_init.h
> -/grub-file
> -/grub-file.exe
>  grub-fstest
>  grub-fstest.exe
>  grub_fstest_init.c
> @@ -72,21 +63,10 @@ grub_func_test
>  grub-install
>  grub-install.exe
>  grub-kbdcomp
> -/grub-macbless
> -/grub-macbless.exe
>  grub-macho2img
> -/grub-menulst2cfg
> -/grub-menulst2cfg.exe
> -/grub-mk*
>  grub-mount
> -/grub-ofpathname
> -/grub-ofpathname.exe
> -grub-core/build-grub-pe2elf.exe
> -/grub-probe
> -/grub-probe.exe
>  grub_probe_init.c
>  grub_probe_init.h
> -/grub-reboot
>  grub_script_blanklines
>  grub_script_blockarg
>  grub_script_break
> @@ -128,26 +108,20 @@ grub-shell
>  grub-shell-tester
>  grub-sparc64-setup
>  grub-sparc64-setup.exe
> -/grub-syslinux2cfg
> -/grub-syslinux2cfg.exe
>  gzcompress_test
>  hddboot_test
>  help_test
>  *.img
>  *.image
>  *.image.exe
> -include/grub/cpu
> -include/grub/machine
>  INSTALL.grub
>  install-sh
> -lib/libgcrypt-grub
>  libgrub_a_init.c
>  *.log
>  *.lst
>  lzocompress_test
>  *.marker
>  Makefile
> -/m4
>  *.mod
>  mod-*.c
>  missing
> @@ -159,14 +133,6 @@ partmap_test
>  pata_test
>  *.pf2
>  *.pp
> -po/*.mo
> -po/grub.pot
> -po/Makefile.in.in
> -po/Makevars
> -po/Makevars.template
> -po/POTFILES
> -po/Rules-quot
> -po/stamp-po
>  printf_test
>  priority_queue_unit_test
>  pseries_test
> @@ -190,13 +156,53 @@ compile
>  depcomp
>  mdate-sh
>  texinfo.tex
> -grub-core/lib/libgcrypt-grub
>  .deps
>  .deps-util
>  .deps-core
>  .dirstamp
>  Makefile.util.am
>  contrib
> +widthspec.bin
> +widthspec.h
> +Makefile.utilgcry.def
> +
> +# Ignore patterns relative to this .gitignore file's directory
> +docs/*.info
> +docs/stamp-vti
> +docs/version.texi

You are doing more in this patch than you said in the commit message.
Please do not do that. Just one logical change per patch please. I would
like to see only currently existing entries prefixed with "/" added here
by this patch. One of subsequent patches should move relevant entries
from above and add here with "/" prefix.

> +/gnulib
> +/grub-bios-setup
> +/grub-bios-setup.exe
> +/grub-editenv
> +/grub-editenv.exe
> +/grub-file
> +/grub-file.exe
> +/grub-macbless
> +/grub-macbless.exe
> +/grub-menulst2cfg
> +/grub-menulst2cfg.exe
> +/grub-mk*
> +/grub-ofpathname
> +/grub-ofpathname.exe
> +grub-core/build-grub-pe2elf.exe

Ditto...

> +/grub-probe
> +/grub-probe.exe
> +/grub-reboot
> +/grub-syslinux2cfg
> +/grub-syslinux2cfg.exe
> +include/grub/cpu
> +include/grub/machine
> +lib/libgcrypt-grub

Ditto and below...

Daniel