grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID


From: Daniel Kiper
Subject: Re: [PATCH] efi: add missed space in GRUB_EFI_GLOBAL_VARIABLE_GUID
Date: Fri, 27 Mar 2020 15:36:31 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Fri, Mar 27, 2020 at 12:50:31PM +0000, Flavio Suligoi wrote:
> Hi Vladimir and Adrian,
>
> > On 3/27/20 1:11 PM, Vladimir 'phcoder' Serbinenko wrote:
> > > Could you explain why we would need this patch? It changes nothing
> > AFAICT
> >
> > It's a cosmetic change, there is one space character missing before the
> > last
> > value in the curly braces:
>
> Exactly, this is a cosmetic patch only.
> I'm working on a new EFI feature for our custom boards and I noticed this
> missed space.
>
> > >>  #define GRUB_EFI_GLOBAL_VARIABLE_GUID \
> > >> -  { 0x8BE4DF61, 0x93CA, 0x11d2, { 0xAA, 0x0D, 0x00, 0xE0, 0x98, 0x03,
> > >> 0x2B,0x8C }}
> > >> +  { 0x8BE4DF61, 0x93CA, 0x11d2, { 0xAA, 0x0D, 0x00, 0xE0, 0x98, 0x03,
> > >> 0x2B, 0x8C }}

I will take this cleanup patch...

Reviewed-by: Daniel Kiper <address@hidden>

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]