grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v1] http: return error on unhandled HTTP error responses


From: Olaf Hering
Subject: [PATCH v1] http: return error on unhandled HTTP error responses
Date: Tue, 17 Mar 2020 19:56:14 +0100

A http transfer will hang if an unhandled error is returned.
The error branch returns the value zero, which is not expected by the caller.

Signed-off-by: Olaf Hering <address@hidden>
---
 grub-core/net/http.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/grub-core/net/http.c b/grub-core/net/http.c
index b616cf40b..9d92a4905 100644
--- a/grub-core/net/http.c
+++ b/grub-core/net/http.c
@@ -125,7 +125,7 @@ parse_line (grub_file_t file, http_data_t data, char *ptr, 
grub_size_t len)
             valid answers like 403 will trigger this very generic message.  */
          data->errmsg = grub_xasprintf (_("unsupported HTTP error %d: %s"),
                                         code, ptr);
-         return GRUB_ERR_NONE;
+         return GRUB_ERR_FILE_READ_ERROR;
        }
       data->first_line_recv = 1;
       return GRUB_ERR_NONE;



reply via email to

[Prev in Thread] Current Thread [Next in Thread]