grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCHv2][ 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function


From: Denis 'GNUtoo' Carikli
Subject: Re: [PATCHv2][ 1/6] cryptodisk: luks: unify grub_cryptodisk_dev function names
Date: Tue, 17 Mar 2020 09:10:02 +0100

I'm sorry to have taken so long.

I ended up being sidetracked with other functionalities I wanted to add
as well along the way, which I'll probably address another time.

I also forgot to use --compose for sending the patches.

As for the changes between the V1 and this one, beside addressing the
comments the main changes are that:
- I've split the patch set between the generic part and the backend
  specific part (like luks1).
- I've renamed the GRUB_FILE_TYPE to match the fact that the file type
  could also be used in geli if it's implemented there.
- I've also added two tiny patches to unify function names as it makes
  the code easier to read afterward.

Denis.

Attachment: pgpr61xeTy_yh.pgp
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]