grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 08/12] kern: Make grub_error() more verbose


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH v2 08/12] kern: Make grub_error() more verbose
Date: Fri, 6 Mar 2020 12:41:25 +0100



Le ven. 6 mars 2020 à 12:38, Javier Martinez Canillas <address@hidden> a écrit :
Hello Vladimir,

Thanks a lot for your feedback.

On 3/5/20 3:22 PM, Vladimir 'phcoder' Serbinenko wrote:
> Please evaluate size increase for this. In the past passing file and line
> number to grub_dprintf was a huge source of increased Kern and core size
>
> Le mer. 4 mars 2020 à 13:01, Javier Martinez Canillas <address@hidden>
> a écrit :
>

For a x86_64-pc build with platform=pc on master with and without the patch:

$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
2740    total

$ find -regex '.*\(mod\|img\|exec\)$' -exec du -c {} + | grep total$
2756    total

so in this case the increase is a 0.6% in size.
This is not the comparison we care about. We care about kernel.img size and core.img size for several common configs. And in bytes.
We have only 31K in mbr gap and every byte counts

reply via email to

[Prev in Thread] Current Thread [Next in Thread]