grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] ZFS/other CoW FS save_env support


From: Daniel Kiper
Subject: Re: [PATCH] ZFS/other CoW FS save_env support
Date: Tue, 25 Feb 2020 13:18:26 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Tue, Feb 25, 2020 at 06:33:09PM +0800, Michael Chang wrote:
> On Mon, Feb 24, 2020 at 10:30:36AM -0800, Paul Dagnelie wrote:
> > On Mon, Feb 24, 2020 at 3:03 AM Daniel Kiper <address@hidden> wrote:
> > >
> > >
> > > Why "root" not "boot"?
> > That was a typo on my part; the code uses grub_guess_root_device to
> > find the devices backing the default grub directory, but in most
> > configurations, this should attempt to locate the boot filesystem
> > instead of the root. I was uncertain of a better way to consistently
> > determine the boot filesystem, and this portion of the code was copied
> > from another GRUB patch
> > (https://build.opensuse.org/package/view_file/openSUSE:Factory/grub2/grub2-grubenv-in-btrfs-header.patch?expand=1).
>
> I used to have the same confusion as well. But I tend to interpret that
> as "root device/filesystem for grub" and thus not from the viewpoint of
> a linux system. Essentially we have been using "root" as the name for
> the environment variable pointing to the grub device in which /boot
> resides and the concept just carried over from it to the description.
>
> So in my opinion it certainly not a typo but rather a common expression
> mentioned by the source code. Although it would become misleading at
> times when people have to take in with the linux system, I still prefer
> to keep it as it wasn't that much a mistake by itself. :)

Maybe it would help if you use "(root)" instead of "root". The former is
closer to proper GRUB syntax for devices. This way you will make aware
the reader that you think about GRUB's (root).

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]