[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed
|
From: |
John Paul Adrian Glaubitz |
|
Subject: |
Re: [PATCH 2/2] build: Disable PIE in TARGET_CCASFLAGS if needed |
|
Date: |
Thu, 20 Feb 2020 17:16:12 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
Hi Mike!
On 2/20/20 7:51 AM, Matt Turner wrote:
> PIE should be disabled in assembly sources as well, or else grub will
> fail to boot.
Indeed. We have always passed -fno-PIE on Debian/sparc64 in the debian/rules
file to TARGET_CCASFLAGS, but it makes more sense to fix the issue in the
configure.ac.
> Bug: https://bugs.gentoo.org/667852
> ---
> configure.ac | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/configure.ac b/configure.ac
> index b5e31c787..e2c783652 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -1263,6 +1263,7 @@ grub_CHECK_LINK_PIE
> # `-fPIE' or '-fpie' and '-pie' in the default specs.
> if [ x"$pie_possible" = xyes ]; then
> TARGET_CFLAGS="$TARGET_CFLAGS -fno-PIE -fno-pie"
> + TARGET_CCASFLAGS="$TARGET_CCASFLAGS -fno-PIE -fno-pie"
> fi
>
> if [ x"$link_nopie_needed" = xyes ] || [ x"$pie_possible" = xyes ]; then
I have not verified yet that fix yet but it makes sense for
the aforementioned reasons.
Thanks for fixing this.
Adrian
--
.''`. John Paul Adrian Glaubitz
: :' : Debian Developer - address@hidden
`. `' Freie Universitaet Berlin - address@hidden
`- GPG: 62FF 8A75 84E0 2956 9546 0006 7426 3B37 F5B5 F913