[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ofnet: Fix incorrect mask for ppc64
|
From: |
Javier Martinez Canillas |
|
Subject: |
Re: [PATCH] ofnet: Fix incorrect mask for ppc64 |
|
Date: |
Fri, 13 Dec 2019 15:33:44 +0100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
Hello Vladimir,
Thanks a lot for your feedback.
On 10/31/19 12:58 PM, Vladimir 'phcoder' Serbinenko wrote:
> Please don't chain swap_bytes32 with le_to_cpu32 as it's a less readable
> equivalent of be_to_cpu32
>
That's correct. In fact I think that the patch is wrong and what we should
do is just to drop the grub_le_to_cpu32() instead. I'll get access to a
ppc64le machine to test and post a v2 doing that.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
- Re: [PATCH] ofnet: Fix incorrect mask for ppc64,
Javier Martinez Canillas <=