[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/6] disk: Implement support for LUKS2
From: |
Patrick Steinhardt |
Subject: |
Re: [PATCH v3 6/6] disk: Implement support for LUKS2 |
Date: |
Fri, 15 Nov 2019 13:55:38 +0100 |
On Fri, Nov 15, 2019 at 01:31:00PM +0100, Daniel Kiper wrote:
> On Wed, Nov 13, 2019 at 02:22:38PM +0100, Patrick Steinhardt wrote:
[snip]
> > + /* Merge the decrypted key material to get the candidate master key. */
> > + gcry_err = AF_merge (hash, split_key, out_key, k->key_size,
> > k->af.stripes);
> > + if (gcry_err)
> > + {
> > + err = grub_crypto_gcry_error (gcry_err);
> > + goto err;
> > + }
> > +
> > + grub_dprintf ("luks2", "Candidate key recovered\n");
> > +
> > +err:
>
> One space before label please.
Out of sheer curiosity: I didn't see this leading space anywhere
else and didn't see it described in grub-dev.texi. Is this
documented somewhere?
Patrick
signature.asc
Description: PGP signature
- Re: [PATCH v3 2/6] json: Implement wrapping interface, (continued)
[PATCH v3 4/6] afsplitter: Move into its own module, Patrick Steinhardt, 2019/11/13
[PATCH v3 1/6] json: Import upstream jsmn-1.1.0, Patrick Steinhardt, 2019/11/13
[PATCH v3 5/6] luks: Move configuration of ciphers into cryptodisk, Patrick Steinhardt, 2019/11/13
[PATCH v3 6/6] disk: Implement support for LUKS2, Patrick Steinhardt, 2019/11/13
[PATCH v4 0/6] Support for LUKS2 disk encryption, Patrick Steinhardt, 2019/11/18
[PATCH v4 1/6] json: Import upstream jsmn-1.1.0, Patrick Steinhardt, 2019/11/18
[PATCH v4 5/6] luks: Move configuration of ciphers into cryptodisk, Patrick Steinhardt, 2019/11/18
[PATCH v4 6/6] disk: Implement support for LUKS2, Patrick Steinhardt, 2019/11/18