[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 4/5] normal/main: Search for specific config files for net
From: |
Javier Martinez Canillas |
Subject: |
Re: [PATCH v4 4/5] normal/main: Search for specific config files for netboot |
Date: |
Mon, 28 Oct 2019 18:22:27 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.1.0 |
On 10/28/19 4:13 PM, Daniel Kiper wrote:
> On Wed, Oct 23, 2019 at 03:00:32PM +0200, Javier Martinez Canillas wrote:
>> From: Paulo Flabiano Smorigo <address@hidden>
>>
>> This patch implements a search for a specific configuration when the config
>> file is on a remoteserver. It uses the following order:
>> 1) DHCP client UUID option.
>> 2) MAC address (in lower case hexadecimal with dash separators);
>> 3) IP (in upper case hexadecimal) or IPv6;
>> 4) The original grub.cfg file.
>>
>> This procedure is similar to what is used by pxelinux and yaboot:
>> http://www.syslinux.org/wiki/index.php/PXELINUX#config
>>
>> Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=873406
>>
>> Signed-off-by: Paulo Flabiano Smorigo <address@hidden>
>> Signed-off-by: Javier Martinez Canillas <address@hidden>
>> Reviewed-by: Daniel Kiper <address@hidden>
>
> Did you at least build test whole patchset? I do not think so.
> Please do that before posting any patch on grub-devel. I do not
> accept any patch which at least does not build. Details below..
I do build and test the functionality for all the posted patches but just
noticed that I was calling configure with the --disable-werror option on
my build script... and that's why I missed these issues.
Sorry about that, I fixed my script now so it won't happen again.
> Plus some nitpicks...
>
I'll address these also in v5, thanks again for your feedback and review.
Best regards,
--
Javier Martinez Canillas
Software Engineer - Desktop Hardware Enablement
Red Hat
- [PATCH v4 0/5] Search for specific config files using UUID, MAC and IP, Javier Martinez Canillas, 2019/10/23
- [PATCH v4 1/5] Add %X option to printf functions, Javier Martinez Canillas, 2019/10/23
- [PATCH v4 3/5] net/dhcp: Set net_<interface>_client{id, uuid} variables from DHCP options, Javier Martinez Canillas, 2019/10/23
- [PATCH v4 2/5] net/dhcp: Consistently use decimal numbers for DHCP/BOOTP options enum, Javier Martinez Canillas, 2019/10/23
- [PATCH v4 4/5] normal/main: Search for specific config files for netboot, Javier Martinez Canillas, 2019/10/23
- [PATCH v4 5/5] docs: Update info with grub.cfg netboot selection order, Javier Martinez Canillas, 2019/10/23