[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/3] Search for specific config files using UUID, MAC and IP
From: |
Daniel Kiper |
Subject: |
Re: [PATCH 0/3] Search for specific config files using UUID, MAC and IP |
Date: |
Tue, 15 Oct 2019 16:37:08 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sat, Oct 05, 2019 at 12:44:24AM +0200, Javier Martinez Canillas wrote:
> Hello,
>
> This series contains some patches that have been carried in Fedora (and
> other distros) for a long time. It allows to fetch GRUB configurations
> that are customized for each machine by using the client UUID, MAC and
> IP addresses as suffixes for the grub.cfg file.
>
> This procedure is similar to what is used by pxelinux and yaboot:
> http://www.syslinux.org/wiki/index.php/PXELINUX#config
>
> Patch #1 sets net_<interface>_client{id,uuid} environment variables by
> using the DHCP client ID and UUID options if these are found.
>
> Patch #2 adds a %X format specifier to make the grub_printf() function
> more similar to printf() and not require to use %x plus grub_toupper().
>
> Finally Patch #3 adds the support to fetch the config files using the
> UUID, MAC and IP as suffixes. If these aren't found, the default GRUB
> config filename is used as a fallback.
Except some nitpicks LGTM. You can repost the patch series or I can
fix these minor things before applying.
Daniel
- [PATCH 1/3] Set net_<interface>_client{id, uuid} variables from DHCP options, (continued)