Re: [PATCH] Don't run f2fs test on systems with PAGE_SIZE > 4KB

[Anatoly Pugachev]

On Tue, Jul 30, 2019 at 1:00 PM John Paul Adrian Glaubitz
<address@hidden> wrote:
> On 7/30/19 10:11 AM, Anatoly Pugachev wrote:
> > don't run f2fs test on systems with PAGE_SIZE > 4096 bytes.
> > Since f2fs is not supported on this systems (can't mount f2fs filesystem).
>
> Some spelling fixes and re-phrasing suggestion:
>
> > Don't run f2fs tests on systems with PAGE_SIZE > 4096 bytes since f2fs
> > is not supported on these systems and mounting a f2fs filesystems fails.
>
> And:
>
> +PAGE_SIZE=$(getconf PAGE_SIZE)
> +F2FS_BLKSIZE=4096
> +if [ $PAGE_SIZE > $F2FS_BLKSIZE ]; then
> + printf "F2FS not supported on PAGE_SIZE(%d) != %d\n" $PAGE_SIZE 
> $F2FS_BLKSIZE
>           ^^^^
>   I would write "f2fs" in lower case here for consistency with the rest of 
> the script.
>
> + exit 77
> +fi

Adrian,

thanks. Attached v2 patch.

0001-Don-t-run-f2fs-tests-on-systems-with-PAGE_SIZE-4096-.patch
Description: Source code patch