grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hostfs: #undef open and close.


From: Daniel Kiper
Subject: Re: [PATCH] hostfs: #undef open and close.
Date: Thu, 6 Jun 2019 10:38:43 +0200
User-agent: NeoMutt/20170113 (1.7.2)

On Tue, Mar 26, 2019 at 12:25:25PM +0100, Daniel Kiper wrote:
> On Mon, Mar 25, 2019 at 04:24:50PM +0100, Vladimir 'phcoder' Serbinenko wrote:
> > >From 0cfd6226d200cce722e99230f5564e1bd9e45eff Mon Sep 17 00:00:00 2001
> > From: Vladimir Serbinenko <address@hidden>
> > Date: Mon, 25 Mar 2019 16:14:54 +0100
> > Subject: [PATCH] hostfs: #undef open and close.
> >
> > Unlike in case of disks in this case it's just a single place, so it's 
> > easier to
> > just #undef
>
> I would prefer if you do the same think like for disks. Just for consistency.

Chatted about that patch with Vladimir. He told me that
it is not safe to change it before the release. So,
conditional Reviewed-by: Daniel Kiper <address@hidden>.
Vladimir promised to post updated version after the release.

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]