Re: [PATCH v3] probe: Support probing for GPT partition UUID with -q

[Jacob Kroon]

Hi Paul,

On Mon, May 13, 2019 at 1:30 PM Paul Menzel <address@hidden> wrote:
>
> Dear Jacob,
>
>
> On 10.05.19 14:05, Jacob Kroon wrote:
> > Linux supports root=PARTUUID=<partuuid> boot argument, so add
> > support for probing it. Compared to the fs UUID, the partition
> > UUID does not change when reformatting a partition.
>
> How did you choose the switch name `-q`? Are other tools using this
> already, or was it just available?
>

Honestly I just picked the first character on the top-left of my keyboard :-)
I'm not sure which char to pick, but I guess maybe 'g' as in gpt would
make more sense ?
Open to suggestions...

> > Signed-off-by: Jacob Kroon <address@hidden>
> > ---
> >   grub-core/commands/probe.c | 35 +++++++++++++++++++++++++++++++++++
> >   1 file changed, 35 insertions(+)
>
> It’d be awesome if you also updated the documentation/manual
> `docs/grub.texi`.
>

Ok, will do.

> > Changes since v2:
> >
> >   * Add a proper commit message
> >   * Handle endianess in the same way as is currently done in
> >     util/grub-probe.c:print_gpt_guid ()
> >
> > diff --git a/grub-core/commands/probe.c b/grub-core/commands/probe.c
> > index 95d272287..24742c181 100644
> > --- a/grub-core/commands/probe.c
> > +++ b/grub-core/commands/probe.c
> > @@ -24,6 +24,7 @@
> >   #include <grub/device.h>
> >   #include <grub/disk.h>
> >   #include <grub/partition.h>
> > +#include <grub/gpt_partition.h>
> >   #include <grub/net.h>
> >   #include <grub/fs.h>
> >   #include <grub/file.h>
> > @@ -45,6 +46,7 @@ static const struct grub_arg_option options[] =
> >       {"fs",          'f', 0, N_("Determine filesystem type."), 0, 0},
> >       {"fs-uuid",             'u', 0, N_("Determine filesystem UUID."), 0, 
> > 0},
> >       {"label",               'l', 0, N_("Determine filesystem label."), 0, 
> > 0},
> > +    {"partuuid",     'q', 0, N_("Determine GPT partition uuid."), 0, 0},
>
> UUID is capitalized in the string above. Do it her too for consistency?
>

Yes, will fix.

Thanks for reviewing,
Regards Jacob