[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] arm: Align section alignment with manual relocation offset c
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] arm: Align section alignment with manual relocation offset code |
|
Date: |
Mon, 29 Apr 2019 11:07:31 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Sun, Apr 28, 2019 at 12:55:42AM +0200, Alexander Graf wrote:
> The arm relocation code has a manual special case for EFI binaries to
> add the natural alignment to its own relocation awareness.
>
> Since commit a51f953f4ee87 ("mkimage: Align efi sections on 4k
> boundary") we changed that alignment from 0x400 to 0x1000 bytes. Reflect
> the change in that branch that we forgot as well.
>
> This fixes running 32bit arm grub efi binaries for me again.
>
> Fixes: a51f953f4ee87 ("mkimage: Align efi sections on 4k boundary")
> Reported-by: Heinrich Schuchardt <address@hidden>
> Reported-by: Steve McIntyre <address@hidden>
> Signed-off-by: Alexander Graf <address@hidden>
Reviewed-by: Daniel Kiper <address@hidden>
However, I will apply this patch if I get some Tested-by and I am sure
that other EFI targets are not affected.
Daniel
PS FYI, I am on vacation this week. So, I will take care about
urgent stuff only. Sorry about that.