[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_d
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH] ieee1275: Null pointer dereference in grub_ieee1275_encode_devname |
|
Date: |
Thu, 4 Apr 2019 20:44:17 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Tue, Apr 02, 2019 at 06:24:07PM +0100, Colin Watson wrote:
> On Tue, Apr 02, 2019 at 09:40:31AM -0700, Eric Snowberg wrote:
> > Function grub_strndup may return NULL, this is called from function
> > grub_ieee1275_get_devname which is then called from function
> > grub_ieee1275_encode_devname to set device. The device variable
> > could then be used with a NULL pointer.
>
> Makes sense to me, and the handling matches how the
> immediately-following possible grub_malloc failure is handled.
>
> Reviewed-by: Colin Watson <address@hidden>
Pushed! Thanks!
Daniel