grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/5] Various GRUB build fixes


From: Ross Philipson
Subject: Re: [PATCH 0/5] Various GRUB build fixes
Date: Tue, 19 Mar 2019 11:16:52 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2

On 03/19/2019 08:39 AM, Daniel Kiper wrote:
> Hey,
> 
> As in subject... I am CC-ing folks who were somehow involved in
> doing/reviewing patches touching broken files. If I missed somebody
> then sorry about that. Anyway, please take a look.
> 
> There are still broken builds which I am going to fix soon. However,
> fortunately most of our targets build without any issue right now.
> 
> Daniel
> 
>  grub-core/kern/compiler-rt.c              | 5 +++--
>  grub-core/loader/ia64/efi/linux.c         | 3 +--
>  grub-core/loader/mips/linux.c             | 2 +-
>  grub-core/loader/powerpc/ieee1275/linux.c | 4 ++--
>  include/grub/compiler-rt.h                | 4 +++-
>  5 files changed, 10 insertions(+), 8 deletions(-)
> 
> Daniel Kiper (5):
>       verifiers: IA-64 fallout cleanup

It seems like the things fixed in these two would have prevented
compiling. I guess it was not tried on these platforms?

>       verifiers: PowerPC fallout cleanup
>       verifiers: MIPS fallout cleanup>       mips: Enable __clzsi2()
>       sparc: Enable __clzsi2() and __clzdi2()
> 

Anyway, LGTM

Reviewed-by: Ross Philipson <address@hidden>



reply via email to

[Prev in Thread] Current Thread [Next in Thread]