Re: [PATCH v6 10/11] RISC-V: Add to build system

[Daniel Kiper]

On Tue, Feb 19, 2019 at 02:44:06PM +0100, Alexander Graf wrote:
> On 02/18/2019 09:14 PM, Daniel Kiper wrote:
> > On Tue, Feb 12, 2019 at 11:31:07AM +0100, Alexander Graf wrote:
> > > This patch adds support for RISC-V to the grub build system. With this
> > > patch, I can successfully build grub on RISC-V as a UEFI application.
> > >
> > > Signed-off-by: Alexander Graf <address@hidden>
> > > Reviewed-by: Alistair Francis <address@hidden>
> > > Reviewed-by: Bin Meng <address@hidden>
> > > Tested-by: Bin Meng <address@hidden>
> > Reviewed-by: Daniel Kiper <address@hidden>
> >
> > But two nitpicks below...
> >
> > [...]
> >
> > > diff --git a/grub-core/kern/emu/cache.c b/grub-core/kern/emu/cache.c
> > > index 6f89e871a..113682cc4 100644
> > > --- a/grub-core/kern/emu/cache.c
> > > +++ b/grub-core/kern/emu/cache.c
> > > @@ -25,5 +25,11 @@ grub_arch_sync_caches (void *address, grub_size_t len)
> > >     return _flush_cache (address, len, 0);
> > >   }
> > >
> > > +#elif defined(__riscv)
> > > +void
> > > +grub_arch_sync_caches (void *address, grub_size_t len)
> > > +{
> > > +}
> > > +
> > Redundant empty line.
> >
> > >   #endif
> > >
> > > diff --git a/grub-core/kern/emu/cache_s.S b/grub-core/kern/emu/cache_s.S
> > > index 76cf7560d..e27b865f9 100644
> > > --- a/grub-core/kern/emu/cache_s.S
> > > +++ b/grub-core/kern/emu/cache_s.S
> > > @@ -9,6 +9,7 @@
> > >   #elif defined(__powerpc__)
> > >   #include "../powerpc/cache.S"
> > >   #elif defined(__ia64__) || defined(__arm__) || defined(__aarch64__) || 
> > > defined(__mips__)
> > > +#elif defined(__riscv)
> > Why not
> >
> > #elif defined(__ia64__) || defined(__arm__) || defined(__aarch64__) || \
> >        defined(__mips__) || defined(__riscv)?
>
> Mostly because I dislike multiline preprocessor macros :).

I hope that you will not object if I replace it with my version... :-)))

Daniel