Re: [PATCH 1/1] Add new module msr

[Paul Menzel]

Dear Jesus,


Thank you very much for your contribution.


On 02/16/19 18:29, JesusDF wrote:

> Add a new grub module called msr that registers two commands (rdmsr and wrmsr)
> to be able to read and write to the model-specific registers. It is i386
> specific, as the cpuid module. The name of the module and commands match the
> linux kernel module and intel commands to interact with it.

I moved the description away from the subject line to the body. Please read,
for example, *How to Write a Git Commit Message* [1] and reformat it with
`git commit --amend`.

I believe a Signed-off-by line is also needed. (Use the switch `-s`:
`git commit --amend -s` in this case.)

> ---
>  grub-core/Makefile.core.def   |  10 ++++
>  grub-core/commands/i386/msr.c | 106 ++++++++++++++++++++++++++++++++++
>  include/grub/i386/msr.h       |  67 +++++++++++++++++++++
>  3 files changed, 183 insertions(+)
>  create mode 100644 grub-core/commands/i386/msr.c
>  create mode 100644 include/grub/i386/msr.h

[…]

Could you please add the appropriate documentation too, and then resend as
v2?


Kind regards,

Paul


[1]: https://chris.beams.io/posts/git-commit/

smime.p7s
Description: S/MIME Cryptographic Signature