Re: [PATCH v4 04/10] RISC-V: Add setjmp implementation

[Daniel Kiper]

On Mon, Nov 26, 2018 at 12:38:09AM +0100, Alexander Graf wrote:
> This patch adds a 32/64 capable setjmp implementation for RISC-V.
>
> Signed-off-by: Alexander Graf <address@hidden>
> Reviewed-by: Alistair Francis <address@hidden>
> Reviewed-by: Bin Meng <address@hidden>
> Tested-by: Bin Meng <address@hidden>

Reviewed-by: Daniel Kiper <address@hidden>

However, one nit pick below...

> ---
>
> v3 -> v4:
>
>   - Change copyright from 2013 to 2018
> ---
>  grub-core/lib/riscv/setjmp.S  | 82 
> +++++++++++++++++++++++++++++++++++++++++++
>  include/grub/riscv32/setjmp.h | 27 ++++++++++++++
>  include/grub/riscv64/setjmp.h | 27 ++++++++++++++
>  3 files changed, 136 insertions(+)
>  create mode 100644 grub-core/lib/riscv/setjmp.S
>  create mode 100644 include/grub/riscv32/setjmp.h
>  create mode 100644 include/grub/riscv64/setjmp.h
>
> diff --git a/grub-core/lib/riscv/setjmp.S b/grub-core/lib/riscv/setjmp.S
> new file mode 100644
> index 000000000..a27a39fae
> --- /dev/null
> +++ b/grub-core/lib/riscv/setjmp.S
> @@ -0,0 +1,82 @@
> +/*
> + *  GRUB  --  GRand Unified Bootloader
> + *  Copyright (C) 2018  Free Software Foundation, Inc.
> + *
> + *  GRUB is free software: you can redistribute it and/or modify
> + *  it under the terms of the GNU General Public License as published by
> + *  the Free Software Foundation, either version 3 of the License, or
> + *  (at your option) any later version.
> + *
> + *  GRUB is distributed in the hope that it will be useful,
> + *  but WITHOUT ANY WARRANTY; without even the implied warranty of
> + *  MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + *  GNU General Public License for more details.
> + *
> + *  You should have received a copy of the GNU General Public License
> + *  along with GRUB.  If not, see <http://www.gnu.org/licenses/>.
> + */
> +
> +#include <grub/symbol.h>
> +#include <grub/dl.h>
> +
> +     .file   "setjmp.S"
> +GRUB_MOD_LICENSE "GPLv3+"

Should not this line be immediately after #include? OK, after one empty
line. But not here.

Daniel