[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 3/3] grub: add extend variable functionality
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v2 3/3] grub: add extend variable functionality |
|
Date: |
Wed, 16 Jan 2019 22:46:54 +0100 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jan 16, 2019 at 01:34:43PM -0500, Prarit Bhargava wrote:
> Customers and users of the kernel are commenting that there is no way to
> update
> a grub variable without copy and pasting the existing data.
>
> For example,
>
> [10:57 AM address@hidden grub-2.02]# ./grub-editenv list
> saved_entry=0
> next_entry=
> kernelopts=root=/dev/mapper/rhel_intel--wildcatpass--07-root ro
> crashkernel=auto resume=/dev/mapper/rhel_intel--wildcatpass--07-swap
> rd.lvm.lv=rhel_intel-wildcatpass-07/root
> rd.lvm.lv=rhel_intel-wildcatpass-07/swap console=ttyS0,115200n81
> ignore_loglevel
> [10:57 AM address@hidden grub-2.02]# ./grub-editenv - set
> kernelopts="root=/dev/mapper/rhel_intel--wildcatpass--07-root ro
> crashkernel=auto resume=/dev/mapper/rhel_intel--wildcatpass--07-swap
> rd.lvm.lv=rhel_intel-wildcatpass-07/root
> rd.lvm.lv=rhel_intel-wildcatpass-07/swap console=ttyS0,115200n81
> ignore_loglevel newarg"
> [10:57 AM address@hidden grub-2.02]# ./grub-editenv list
> saved_entry=0
> next_entry=
> kernelopts=root=/dev/mapper/rhel_intel--wildcatpass--07-root ro
> crashkernel=auto resume=/dev/mapper/rhel_intel--wildcatpass--07-swap
> rd.lvm.lv=rhel_intel-wildcatpass-07/root
> rd.lvm.lv=rhel_intel-wildcatpass-07/swap console=ttyS0,115200n81
> ignore_loglevel newarg
>
> which is cumbersome.
>
> Add functionality to add to an existing variable. For example,
>
> [10:58 AM address@hidden grub-2.02]# ./grub-editenv list
> saved_entry=0
> next_entry=
> kernelopts=root=/dev/mapper/rhel_intel--wildcatpass--07-root ro
> crashkernel=auto resume=/dev/mapper/rhel_intel--wildcatpass--07-swap
> rd.lvm.lv=rhel_intel-wildcatpass-07/root
> rd.lvm.lv=rhel_intel-wildcatpass-07/swap console=ttyS0,115200n81
> ignore_loglevel
> [10:58 AM address@hidden grub-2.02]# ./grub-editenv - set kernelopts+="newarg"
> [10:59 AM address@hidden grub-2.02]# ./grub-editenv list
> saved_entry=0
> next_entry=
> kernelopts=root=/dev/mapper/rhel_intel--wildcatpass--07-root ro
> crashkernel=auto resume=/dev/mapper/rhel_intel--wildcatpass--07-swap
> rd.lvm.lv=rhel_intel-wildcatpass-07/root
> rd.lvm.lv=rhel_intel-wildcatpass-07/swap console=ttyS0,115200n81
> ignore_loglevel newarg
>
> Signed-off-by: Prarit Bhargava <address@hidden>
I prefer v1 patch +/- my suggestions. IMO current solution is an overkill.
Daniel