Re: [PATCH v6.1 09/20] xen: add basic hooks for PVH in current code

[Juergen Gross]

On 07/12/2018 12:50, Daniel Kiper wrote:
> On Fri, Dec 07, 2018 at 08:35:26AM +0100, Juergen Gross wrote:
>> Add the hooks to current code needed for Xen PVH. They will be filled
>> with code later when the related functionality is being added.
>>
>> loader/i386/linux.c needs to include machine/kernel.h now as it needs
>> to get GRUB_KERNEL_USE_RSDP_ADDR from there. This in turn requires to
>> add an empty kernel.h header for some i386 platforms (efi, coreboot,
>> ieee1275, xen).
>>
>> Signed-off-by: Juergen Gross <address@hidden>
>> Reviewed-by: Daniel Kiper <address@hidden>
>> ---
>> V3: xenpvh->xen_pvh (Daniel Kiper)
>>     adjust copyright date (Roger Pau Monné)
>> V5: update commit message (Daniel Kiper)
>>     move including xen/hvm/start_info.h to the sources really needing
>>       it (Daniel Kiper)
>> V6.1: add empty kernel.h headers for i386 platforms
> 
> After this patch "xen_pvh: add build runes for grub-core" does not apply
> any longer. May I ask you to rebase whole patch series on latest master
> and resend it as v7?

Okay.

> 
>>     It should be noted that i386_efi build is broken even without this
>>     patch, but this is clearly beyond the scope of this series.
> 
> Could you tell me how exactly building fails?

No. It doesn't now. I head to do a "git clean" in order to be able to
rebase my patches on the most actual master. Seems as if there was some
stale file in my tree causing the build to fail.

> Have you tested x86_64 efi and xen builds?

x86_64 efi needs the header, too. Will be in V7.

Xen builds are working (now, with your fixup patches in place).


Juergen