Re: [GRUB PATCH 1/2] verifiers: Xen fallout cleanup

[Ross Philipson]

On 12/06/2018 10:40 AM, Daniel Kiper wrote:
> On Thu, Dec 06, 2018 at 10:37:43AM -0500, Ross Philipson wrote:
>> On 12/06/2018 08:40 AM, Daniel Kiper wrote:
>>> Xen fallout cleanup after commit ca0a4f689 (verifiers: File type for
>>> fine-grained signature-verification controlling).
>>>
>>> Signed-off-by: Daniel Kiper <address@hidden>
>>> ---
>>>  grub-core/loader/i386/xen.c | 14 +++++++-------
>>>  1 file changed, 7 insertions(+), 7 deletions(-)
>>>
>>> diff --git a/grub-core/loader/i386/xen.c b/grub-core/loader/i386/xen.c
>>> index 1a99ca72c..8f662c8ac 100644
>>> --- a/grub-core/loader/i386/xen.c
>>> +++ b/grub-core/loader/i386/xen.c
>>> @@ -645,10 +645,10 @@ grub_cmd_xen (grub_command_t cmd __attribute__ 
>>> ((unused)),
>>>
>>>    grub_xen_reset ();
>>>
>>> -  grub_create_loader_cmdline (argc - 1, argv + 1,
>>> -                         (char *) xen_state.next_start.cmd_line,
>>> -                         sizeof (xen_state.next_start.cmd_line) - 1);
>>> -  err = grub_verify_string (xen_state.next_start.cmd_line, 
>>> GRUB_VERIFY_MODULE_CMDLINE);
>>> +  err = grub_create_loader_cmdline (argc - 1, argv + 1,
>>> +                               (char *) xen_state.next_start.cmd_line,
>>> +                               sizeof (xen_state.next_start.cmd_line) - 1,
>>> +                               GRUB_VERIFY_KERNEL_CMDLINE);
>>
>> How did this compile previously if you were missing an argument to
>> grub_create_loader_cmdline?
> 
> This is only build if xen platform is enabled. Otherwise this file is
> not used.

Ack, that is what I was starting to guess happened. For the series:

Reviewed-by: Ross Philipson <address@hidden>

> 
> Daniel
>