grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs


From: Nick Terrell
Subject: Re: [PATCH v6 2/2] btrfs: Add zstd support to grub btrfs
Date: Mon, 19 Nov 2018 17:58:11 +0000

> On Nov 19, 2018, at 7:11 AM, Daniel Kiper <address@hidden> wrote:
> 
>> On Mon, Nov 19, 2018 at 03:22:51PM +0100, Daniel Kiper wrote:
>>> On Thu, Nov 15, 2018 at 02:36:03PM -0800, Nick Terrell wrote:
>>> - Adds zstd support to the btrfs module.
>>> - Adds a test case for btrfs zstd support.
>>> - Changes top_srcdir to srcdir in the btrfs module's lzo include
>>>  following comments from Daniel Kiper about the zstd include.
>>> 
>>> Tested on Ubuntu-18.04 with a btrfs /boot partition with and without zstd
>>> compression. A test case was also added to the test suite that fails before
>>> the patch, and passes after.
>>> 
>>> Signed-off-by: Nick Terrell <address@hidden>
>> 
>> Reviewed-by: Daniel Kiper <address@hidden>
>> 
>> If there are no objections I will apply this patch series in a week or so.
> 
> Errr... I have just realized that there are two many spaces just at the
> beginning of most lines. There should be 2 instead of 4. Please take
> a look at currently existing functions. Anyway, I can fix this before
> committing. However, if you could repost whole patch series that would
> be much easier for me.

I’ll send a new version with the formatting changes.

> Daniel

-Nick

reply via email to

[Prev in Thread] Current Thread [Next in Thread]