[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] hostdisk: Fix linux disk cache workaround on multipath disks

From: Daniel Kiper
Subject: Re: [PATCH] hostdisk: Fix linux disk cache workaround on multipath disks
Date: Tue, 4 Sep 2018 16:46:31 +0200
User-agent: Mutt/1.3.28i

On Wed, Jul 25, 2018 at 04:49:15PM +0800, Michael Chang wrote:
> In hostdisk.c::grub_util_fd_open_device, there's a workaround to linux disk


> cache described below.
> "Linux has a bug that the disk cache for a whole disk is not consistent with
> the one for a partition of the disk."
> The workaround will result in using the partition device for writing the image

Which workaround are you referring to?

> of which the address offset is calculated to be within it's range, to avoid 
> the
> cache problem of the whole disk device.

This sentence is convoluted. Please fix this.

> This patch fixed the linux disk cache workaround not being effective for


> multipath/dm device because its partition device cannot be correctly 
> determined
> by grub_hostdisk_linux_find_partition function.

In general I am not happy with the commit message. It is difficult to
understand where the problem is and why and how it is fixed.

And lack of SOB...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]