Re: [PATCH 5/9] btrfs: Move logging code in grub_btrfs_read_logical()

[Daniel Kiper]

On Sun, Jun 03, 2018 at 08:53:44PM +0200, Goffredo Baroncelli wrote:
> A portion of the logging code is moved outside of internal for(;;). The part
> that is left inside is the one which depends by the internal for(;;) index.

s/depends by/depends on/

> This is a preparatory patch: in the next one it will be possible to refactor

s/: in the next one it will be possible to/. The next one will/

> the code inside the for(;;) in an another function.

s/in/into/

> Signed-off-by: Goffredo Baroncelli <address@hidden>
> ---
>  grub-core/fs/btrfs.c | 25 ++++++++++++++-----------
>  1 file changed, 14 insertions(+), 11 deletions(-)
>
> diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
> index b64b692f8..e2baed665 100644
> --- a/grub-core/fs/btrfs.c
> +++ b/grub-core/fs/btrfs.c
> @@ -867,6 +867,18 @@ grub_btrfs_read_logical (struct grub_btrfs_data *data, 
> grub_disk_addr_t addr,
>
>       for (j = 0; j < 2; j++)
>         {
> +         grub_dprintf ("btrfs", "chunk 0x%" PRIxGRUB_UINT64_T
> +                       "+0x%" PRIxGRUB_UINT64_T
> +                       " (%d stripes (%d substripes) of %"
> +                       PRIxGRUB_UINT64_T ") \n",

s/") \n"/")\n"/

Otherwise LGTM.

Daniel