grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning


From: Oleg Solovyov
Subject: Re: [PATCH] Enable /dev/mapper/dm-[0-9]-* scanning
Date: Tue, 29 May 2018 16:55:10 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0

29.05.2018 16:50, Vladimir 'phcoder' Serbinenko пишет:


On Tue, 29 May 2018, 13:58 Oleg Solovyov, <address@hidden> wrote:
Anybody?
Why do you need this? Normally the same devices should be under /dev/mapper. Using dm-X will mess up some other code most likely
What happens if you have /dev/mapper/dm-0-luks symlinked to /dev/dm-0?
This device will be skipped because basename starts with dm-0
There's no checking whether device is under /dev/mapper or not yet.


14.05.2018 20:13, Daniel Kiper пишет:
> On Fri, May 11, 2018 at 02:32:48PM +0300, Oleg Solovyov wrote:
>> Thanks for review
>> New version is attached
>>
>> From 19e3f13632a20a0b1be12b6d6ff4c52ba4f3b4d6 Mon Sep 17 00:00:00 2001
>> From: Oleg Solovyov <address@hidden>
>> Date: Fri, 11 May 2018 13:55:46 +0300
>> Subject: [PATCH] Don't skip /dev/mapper/dm-* devices
>>
>> This patch ensures that grub-probe will find the root device placed in
>> /dev/mapper/dm-[0-9]+-.*
>> e.g. device named /dev/mapper/dm-0-luks will be found and grub.cfg will
>> be updated properly, enabling the system to boot.
>>
>> Signed-off-by: Oleg Solovyov <address@hidden>
> Reviewed-by: Daniel Kiper <address@hidden>
>
> If there are no objections I will apply this patch in a week or so.
>
> Next time please use "git send-email" to send the patches.
>
> Daniel
>
> _______________________________________________
> Grub-devel mailing list
> address@hidden
> https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel


_______________________________________________
Grub-devel mailing list
address@hidden
https://lists.gnu.org/mailman/listinfo/grub-devel

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]