[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/8] Refactor the code that read from disk
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 5/8] Refactor the code that read from disk |
|
Date: |
Mon, 14 May 2018 20:44:27 +0200 |
|
User-agent: |
Mutt/1.3.28i |
On Mon, May 14, 2018 at 08:26:40PM +0200, Daniel Kiper wrote:
> It looks that patch 4 is missing in this series.
>
> On Fri, May 11, 2018 at 09:24:43PM +0200, Goffredo Baroncelli wrote:
> > This is a preparatory patch, to help the adding of the raid5/6 recovery
> > code.
> > In case of availability of all disks, this code is good for all the RAID
> > profiles. However in case of failure, the error handling is quite different.
> > Refactoring this code increases the general readability.
>
> s/raid/RAID/ in all patches please. And use "RAID 5" and "RAID 6" (with
> space between RAID and number) respectively.
Of course I thought about the commit messages and comments. Code you
can leave as is.
Daniel
[PATCH 2/8] Add helper to check the btrfs header., Goffredo Baroncelli, 2018/05/11
[PATCH 6/8] Add support for recovery for a raid5 btrfs profiles., Goffredo Baroncelli, 2018/05/11